clang tidy fixes (#1365)

* fix tidy warings related to passing const container.

readability-avoid-const-params-in-decls
performance-unnecessary-value-param

* tidy readability-inconsistent-declaration-parameter-name

* tidy cppcoreguidelines-prefer-member-initializer

* tidy readability-redundant-member-init

* tidy modernize-loop-convert

* tidy modernize-type-traits

* tidy readability-named-parameter

diff --git a/bend.h b/bend.h
index fd7b101d5c325bd4381f559baff404e23338830c..4e2cfda1139261be0e55dd2e80151784183f6db9 100644 (file)
--- a/bend.h
+++ b/bend.h
@@ -64,7 +64,7 @@ private:
     },
   };
 
-  Waypoint* create_wpt_dest(const Waypoint* wpt_orig, const Waypoint* wpt_adj) const;
+  Waypoint* create_wpt_dest(const Waypoint* wpt_orig, const Waypoint* wpt_orig_adj) const;
   int is_small_angle(const Waypoint* wpt_orig,
                      const Waypoint* wpt_orig_prev,
                      const Waypoint* wpt_orig_next) const;

diff --git a/garmin_tables.cc b/garmin_tables.cc
index 09bd9457604422e6b05a8ffb27dec094bf0a0884..0560b96c3c5d305713b9ed350f0f3dd4d366a4f6 100644 (file)
--- a/garmin_tables.cc
+++ b/garmin_tables.cc
@@ -730,9 +730,9 @@ gt_color_value(const unsigned int garmin_index)
 uint32_t
 gt_color_value_by_name(const QString& name)
 {
-  for (int i = 0; i < gt_colors.size(); ++i) {
-    if (QString::compare(gt_colors[i].name, name, Qt::CaseInsensitive) == 0) {
-      return gt_colors[i].rgb;
+  for (const auto& gt_color : gt_colors) {
+    if (QString::compare(gt_color.name, name, Qt::CaseInsensitive) == 0) {
+      return gt_color.rgb;
     }
   }
 

diff --git a/humminbird.h b/humminbird.h
index 9892e9b2904a0707ebb2a054346ee34d3d507d4d..67a210345dd7a37fc7536f704261ad723590877a 100644 (file)
--- a/humminbird.h
+++ b/humminbird.h
@@ -165,15 +165,14 @@ private:
 
   void humminbird_rte_head(const route_head* rte);
   void humminbird_rte_tail(const route_head* rte);
-  static QString wpt_to_id(const Waypoint*);
+  static QString wpt_to_id(const Waypoint* wpt);
   void humminbird_write_rtept(const Waypoint* wpt) const;
   void humminbird_write_waypoint(const Waypoint* wpt);
   void humminbird_write_waypoint_wrapper(const Waypoint* wpt);
 
   /* Data Members */
 
-  QVector<arglist_t> humminbird_args = {
-  };
+  QVector<arglist_t> humminbird_args;
 };
 
 class HumminbirdHTFormat : public Format, private HumminbirdBase
@@ -214,8 +213,7 @@ private:
 
   /* Data Members */
 
-  QVector<arglist_t> humminbirdht_args = {
-  };
+  QVector<arglist_t> humminbirdht_args;
 };
 
 #endif // HUMMINBIRD_H_INCLUDED_

diff --git a/igc.h b/igc.h
index edda6616e15c62e8ba1f56134d580f2a62902dc7..ff0ca964ea133b211022a29d67b65ae3e2d9f73e 100644 (file)
--- a/igc.h
+++ b/igc.h
@@ -87,7 +87,7 @@ public:
   // Qt6 falls back to std::hash, but it may not use the seed.
   friend size_t qHash(const igc_ext_type_t& key, size_t seed = 0) noexcept
   {
-    return qHash(static_cast<std::underlying_type<igc_ext_type_t>::type>(key), seed);
+    return qHash(static_cast<std::underlying_type_t<igc_ext_type_t>>(key), seed);
   }
 
   QVector<arglist_t>* get_args() override

diff --git a/reverse_route.h b/reverse_route.h
index 4834c78b8b7a729ec7403068a43066d69b2a7816..8ae15e8db95a3eea276c07dca0fe272c36db4d70 100644 (file)
--- a/reverse_route.h
+++ b/reverse_route.h
@@ -40,8 +40,7 @@ public:
 
 private:
   int prev_new_trkseg{};
-  QVector<arglist_t> args = {
-  };
+  QVector<arglist_t> args;
 
   void reverse_route_wpt(const Waypoint* waypointp);
   void reverse_route_head(const route_head* rte);

diff --git a/src/core/nvector.cc b/src/core/nvector.cc
index f6e8ad8940c8d01f5755ee2b11c0db2eb8292548..17cd4b962557e1772deb141cb72e1e6935182f99 100644 (file)
--- a/src/core/nvector.cc
+++ b/src/core/nvector.cc
@@ -31,10 +31,10 @@
 namespace gpsbabel
 {
 
-LatLon::LatLon(double latitude, double longitude)
+LatLon::LatLon(double latitude, double longitude) : lat(latitude), lon(longitude)
 {
-  lat = latitude;
-  lon = longitude;
+  
+  
 }
 
 NVector::NVector(double latitude_degrees, double longitude_degrees)

diff --git a/swapdata.h b/swapdata.h
index 0f829f8bbf84be7fcbf87239a420f6f78bbafca3..ce5f9cf44cb58e0981eabb10c4fde34fca16cb62 100644 (file)
--- a/swapdata.h
+++ b/swapdata.h
@@ -40,8 +40,7 @@ public:
   void process() override;
 
 private:
-  QVector<arglist_t> args = {
-  };
+  QVector<arglist_t> args;
 
   static void swapdata_cb(const Waypoint* ref);
 

diff --git a/xmlgeneric.cc b/xmlgeneric.cc
index 29c8bf3621ac94384c309bc81c180b307ca31afe..8d4d3e755f2ced2a1bf96a0921e31c53847724c5 100644 (file)
--- a/xmlgeneric.cc
+++ b/xmlgeneric.cc
@@ -67,7 +67,7 @@ XmlGenericReader::xml_tbl_lookup(const QString& tag, xg_cb_type cb_type)
 
 void
 XmlGenericReader::xml_common_init(const QString& fname, const char* encoding,
-         const QStringList ignorelist, const QStringList skiplist)
+         const QStringList& ignorelist, const QStringList& skiplist)
 {
   rd_fname = fname;
 

diff --git a/xmlgeneric.h b/xmlgeneric.h
index dd1bb86a563f057615d7dc62978591e228144452..c4e0413384ee9b3769b3a78ee19df622a54c84f5 100644 (file)
--- a/xmlgeneric.h
+++ b/xmlgeneric.h
@@ -89,8 +89,8 @@ public:
   template<class MyFormat>
   void xml_init(const QString& fname, MyFormat* instance, const QList<xg_fmt_map_entry<MyFormat>>& tbl,
                 const char* encoding = nullptr,
-                const QStringList ignorelist = QStringList(),
-                const QStringList skiplist = QStringList())
+                const QStringList& ignorelist = QStringList(),
+                const QStringList& skiplist = QStringList())
   {
     build_xg_tag_map(instance, tbl);
 
@@ -165,7 +165,7 @@ private:
 
   XgCallbackBase* xml_tbl_lookup(const QString& tag, xg_cb_type cb_type);
   void xml_common_init(const QString& fname, const char* encoding,
-                       const QStringList ignorelist, const QStringList skiplist);
+                       const QStringList& ignorelist, const QStringList& skiplist);
   xg_shortcut xml_shortcut(QStringView name);
   void xml_run_parser(QXmlStreamReader& reader);